Make cdylib crate type optional #196
Open
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 1, 2025
|
Ah, it looks like this is not going to work? error: `crate_type` within an `#![cfg_attr]` attribute is forbidden
--> rustls-platform-verifier/src/lib.rs:5:33
|
5 | #![cfg_attr(feature = "cdylib", crate_type = "cdylib")]
| ^^^^^^^^^^^^^^^^^^^^^
error: could not compile `rustls-platform-verifier` (lib) due to 1 previous error |
|
Meh, apparently this hack is not possible anymore. What do you actually use the library in? Maybe the respective test-run can be adjusted to explicitly compile a |
filmor
force-pushed
the
optional-cdylib
branch
from
4c3dc15 to
a994e54
Compare
|
@djc I have adjusted the only user of the cdylib I could find, can you approve the workflow runs? |
djc
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rusterlium/rustler#707.
The cdylib is built unconditionally, which leads to it always being included in deployment processes that parse cargo's messages. This change should make the cdylib optional.